lkml.org 
[lkml]   [2019]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 01/12] net: hns3: fix VLAN initialization to be compatible with port base insert VLAN
From
From: tanhuazhong <tanhuazhong@huawei.com>
Date: Fri, 12 Apr 2019 10:30:38 +0800

>
>
> On 2019/4/12 2:20, David Miller wrote:
>> From: Huazhong Tan <tanhuazhong@huawei.com>
>> Date: Thu, 11 Apr 2019 20:25:20 +0800
>>
>>> From: Jian Shen <shenjian15@huawei.com>
>>>
>>> This patch fixes VLAN initialization, in order to be compatible
>>> with VLAN inserted base on port.
>> This doesn't mean anything to me.
>> Why was normal VLAN initialization different, and how is the behavior
>> of VLAN's configured when inserted based upon port different and why
>> is it better?
>> You have to improve your commit log messages so that someone not
>> intimately familiar with your driver and code can understand what you
>> are doing and why.
>>
>
> Sorry, I will describe it in detail.
>
> Our hardware supports insert a specified vlan header for each function
> when send packets. User can enable it with command "ip link set
> <devname> vf <vfid> vlan <vlan id>". For this vlan header is inserted
> by hardware, not from stack, hardware also needs to strip it from
> received packet before upstreaming to stack. In this case, driver
> needs to tell hardware which vlan to insert or strip.

Don't tell me here, rewrite all of your commit messages for this patch
series so that they explain these k inds of details.

That is what I am asking you to do.

Thank you.

\
 
 \ /
  Last update: 2019-04-12 06:27    [W:0.057 / U:1.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site