lkml.org 
[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] dns: remove redundant zero length namelen check
From
From: Colin King <colin.king@canonical.com>
Date: Tue, 9 Apr 2019 13:59:12 +0100

> From: Colin Ian King <colin.king@canonical.com>
>
> The zero namelen check is redundant as it has already been checked
> for zero at the start of the function. Remove the redundant check.
>
> Addresses-Coverity: ("Logically Dead Code")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to net-next.

However it does look like two sets of semantics were considered.
In one case rejecting a zero namelen and in another having it
mean whatever the strings length is modulo the max of 256.

\
 
 \ /
  Last update: 2019-04-11 23:02    [W:0.055 / U:3.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site