lkml.org 
[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/9] livepatch: Create and include UAPI headers
> >> +
> >> +/*
> >> + * livepatch.h - Kernel Live Patching Core
> >> + *
> >> + * Copyright (C) 2016 Josh Poimboeuf <jpoimboe@redhat.com>
> >> + */
> >> +
> >> +#ifndef _UAPI_LIVEPATCH_H
> >> +#define _UAPI_LIVEPATCH_H
> >> +
> >> +#include <linux/types.h>
> >
> >
> > Why is this include needed?
> >
> >> +#define KLP_RELA_PREFIX ".klp.rela."
> >> +#define KLP_SYM_PREFIX ".klp.sym."
> >
> > These do not depend on <linux/types.h>
> >
>
> Hmmm, types.h has been included since v1, but I just verified that removing it
> results in a clean build, so you are correct that it is (now) unnecessary.

Yes, I mentioned it while reviewing v2. Unfortunately, it seems to get
lost due to unexplained submitting hiccups. Better to walk through my
emails again and make sure nothing more falls through the cracks...

Miroslav

\
 
 \ /
  Last update: 2019-04-11 20:42    [W:0.080 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site