[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net-next 01/12] net: hns3: fix VLAN initialization to be compatible with port base insert VLAN
From: Huazhong Tan <>
Date: Thu, 11 Apr 2019 20:25:20 +0800

> From: Jian Shen <>
> This patch fixes VLAN initialization, in order to be compatible
> with VLAN inserted base on port.

This doesn't mean anything to me.

Why was normal VLAN initialization different, and how is the behavior
of VLAN's configured when inserted based upon port different and why
is it better?

You have to improve your commit log messages so that someone not
intimately familiar with your driver and code can understand what you
are doing and why.

 \ /
  Last update: 2019-04-11 20:21    [W:0.125 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site