lkml.org 
[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650
On Tue, Apr 9, 2019 at 10:38 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> wt., 9 kwi 2019 o 13:04 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
> >
> > wt., 9 kwi 2019 o 03:10 Rob Herring <robh@kernel.org> napisał(a):
> > >
> > > On Mon, Apr 8, 2019 at 7:25 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > >
> > > > sob., 6 kwi 2019 o 09:07 Rob Herring <robh@kernel.org> napisał(a):
> > > > >
> > > > > On Wed, Apr 03, 2019 at 11:00:59AM +0200, Bartosz Golaszewski wrote:
> > > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > >
> > > > > > Add the DT binding document for the battery charger module of max77650.
> > > > > >
> > > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > > > > ---
> > > > > > .../power/supply/max77650-charger.txt | 27 +++++++++++++++++++
> > > > > > 1 file changed, 27 insertions(+)
> > > > > > create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > > > > > new file mode 100644
> > > > > > index 000000000000..fef188144386
> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > > > > > @@ -0,0 +1,27 @@
> > > > > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> > > > > > +
> > > > > > +This module is part of the MAX77650 MFD device. For more details
> > > > > > +see Documentation/devicetree/bindings/mfd/max77650.txt.
> > > > > > +
> > > > > > +The charger is represented as a sub-node of the PMIC node on the device tree.
> > > > > > +
> > > > > > +Required properties:
> > > > > > +--------------------
> > > > > > +- compatible: Must be "maxim,max77650-charger"
> > > > > > +
> > > > > > +Optional properties:
> > > > > > +--------------------
> > > > > > +- min-microvolt: Minimum CHGIN regulation voltage (in microvolts). Must be
> > > > > > + one of: 4000000, 4100000, 4200000, 4300000, 4400000,
> > > > > > + 4500000, 4600000, 4700000.
> > > > > > +- current-limit-microamp: CHGIN input current limit (in microamps). Must
> > > > > > + be one of: 95000, 190000, 285000, 380000, 475000.
> > > > >
> > > > > To repeat what I said on v6, these should be common properties IMO (and
> > > > > therefore documented as such).
> > > > >
> > > >
> > > > Do you mean a separate "charger.txt" document in
> > > > Documentation/devicetree/bindings/power/supply/?
> > >
> > > Yes, though I thought we had something already.
> > >
> > > Rob
> >
> > We don't AFAICT. There's only a binding document for "simple-battery"
> > in power supply.
> >
> > Bart
>
> Can we have it locally for now but without the maxim prefix and then
> reuse it if any other charger needs such functionality? To make it
> even more generic we can name it: "input-voltage-min-microvolt" &
> "input-current-limit-microamp".

I guess. And defining these as 'input' is good because we do have
similar property names already for battery current limit and voltages.

Rob

\
 
 \ /
  Last update: 2019-04-11 18:51    [W:0.067 / U:22.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site