lkml.org 
[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] memstick: remove set but not used variable 'data'
From
Date
On 2019/4/11 19:01, Ulf Hansson wrote:
> On Thu, 11 Apr 2019 at 04:48, YueHaibing <yuehaibing@huawei.com> wrote:
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/memstick/host/jmb38x_ms.c: In function 'jmb38x_ms_issue_cmd':
>> drivers/memstick/host/jmb38x_ms.c:371:17: warning:
>> variable 'data' set but not used [-Wunused-but-set-variable]
>>
>> It's never used since introduction and can be removed.
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Applied for next (to my mmc tree), thanks!
>
> Next time, please post to linux-mmc as well.

Ok, Thanks!

>
> Kind regards
> Uffe
>
>
>> ---
>> drivers/memstick/host/jmb38x_ms.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
>> index e3a5af65dbce..acec09813419 100644
>> --- a/drivers/memstick/host/jmb38x_ms.c
>> +++ b/drivers/memstick/host/jmb38x_ms.c
>> @@ -368,7 +368,6 @@ static int jmb38x_ms_transfer_data(struct jmb38x_ms_host *host)
>> static int jmb38x_ms_issue_cmd(struct memstick_host *msh)
>> {
>> struct jmb38x_ms_host *host = memstick_priv(msh);
>> - unsigned char *data;
>> unsigned int data_len, cmd, t_val;
>>
>> if (!(STATUS_HAS_MEDIA & readl(host->addr + STATUS))) {
>> @@ -400,8 +399,6 @@ static int jmb38x_ms_issue_cmd(struct memstick_host *msh)
>> cmd |= TPC_WAIT_INT;
>> }
>>
>> - data = host->req->data;
>> -
>> if (!no_dma)
>> host->cmd_flags |= DMA_DATA;
>>
>>
>>
>
> .
>

\
 
 \ /
  Last update: 2019-04-11 14:24    [W:0.065 / U:3.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site