lkml.org 
[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-sunxi] [PATCH v3 03/11] pinctrl: sunxi: Prepare for alternative bias voltage setting methods
On Thu, Apr 11, 2019 at 08:34:33PM +1000, Julian Calaby wrote:
> Hi Ondrej
>
> On Thu, Apr 11, 2019 at 8:19 PM megous via linux-sunxi
> <linux-sunxi@googlegroups.com> wrote:
> >
> > From: Ondrej Jirman <megous@megous.com>
> >
> > H6 has a different I/O voltage bias setting method than A80. Prepare
> > existing code for using alternative bias voltage setting methods.
> >
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
> > diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.h b/drivers/pinctrl/sunxi/pinctrl-sunxi.h
> > index ee15ab067b5f..4bfc8a6d9dce 100644
> > --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.h
> > +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.h
> > @@ -95,6 +95,13 @@
> > #define PINCTRL_SUN7I_A20 BIT(7)
> > #define PINCTRL_SUN8I_R40 BIT(8)
> >
> > +enum sunxi_desc_bias_voltage {
> > + BIAS_VOLTAGE_NONE,
> > + /* Bias voltage configuration is done through
> > + * Pn_GRP_CONFIG registers, as seen on A80 SoC. */
> > + BIAS_VOLTAGE_GRP_CONFIG,
> > +};
> > +
> > struct sunxi_desc_function {
> > unsigned long variant;
> > const char *name;
> > @@ -117,7 +124,7 @@ struct sunxi_pinctrl_desc {
> > const unsigned int *irq_bank_map;
> > bool irq_read_needs_mux;
> > bool disable_strict_mode;
> > - bool has_io_bias_cfg;
> > + int io_bias_cfg_variant;
>
> Shouldn't we be defining this field using the enum rather than as an int?

Yes, thank you, I fixed it for v4.

regards,
o.

> Thanks,
>
> --
> Julian Calaby
>
> Email: julian.calaby@gmail.com
> Profile: http://www.google.com/profiles/julian.calaby/

\
 
 \ /
  Last update: 2019-04-11 12:45    [W:0.042 / U:11.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site