lkml.org 
[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel
From
On April 11, 2019 11:13:03 AM GMT+02:00, Junichi Nomura <j-nomura@ce.jp.nec.com> wrote:
>On 4/11/19 5:37 PM, Borislav Petkov wrote:
>> On Thu, Apr 11, 2019 at 08:16:45AM +0000, Junichi Nomura wrote:
>>> kexec_get_rsdp_addr() might fail on kexec-booted kernel, e.g. if the
>>> setup_data was invalid. In such a case, falling back to
>efi_get_rsdp_addr()
>>> will hit the problem of accessing invalid table pointer again.
>>
>> Then you need to do this:
>>
>> if (kexeced kernel) {
>> addr = kexec_get_rsdp_addr();
>> if (!addr) {
>> /* cannot get address */
>> return -1;
>> }
>>
>> return addr;
>> }
>>
>> and the calling function get_rsdp_addr() must check the return value
>and
>> if it is not 0, return immediately.
>
>Do you mean making get_rsdp_addr() like this?

Does that look like what I've typed above?

--
Sent from a small device: formatting sux and brevity is inevitable.

\
 
 \ /
  Last update: 2019-04-11 11:22    [W:0.070 / U:3.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site