lkml.org 
[lkml]   [2019]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority
On Wed, Apr 3, 2019 at 1:32 PM Douglas Anderson <dianders@chromium.org> wrote:
> +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev,
> + struct cros_ec_command *ec_msg,
> + cros_ec_xfer_fn_t fn)
> +{
> + struct cros_ec_xfer_work_params params;
> +
> + INIT_WORK(&params.work, cros_ec_xfer_high_pri_work);

Sorry for the late review, but this should have been
INIT_WORK_ONSTACK(). Should it be a new patch, or is this in a
non-rebasing tree yet?

Otherwise, looks fine to me:

Reviewed-by: Brian Norris <briannorris@chromium.org>

\
 
 \ /
  Last update: 2019-04-12 03:28    [W:0.079 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site