lkml.org 
[lkml]   [2019]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data
On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote:
> On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote:
> > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
> > index bafb2c30e7fb..b0623c936940 100644
> > --- a/drivers/staging/rtl8723bs/include/drv_types.h
> > +++ b/drivers/staging/rtl8723bs/include/drv_types.h
> > @@ -220,7 +220,7 @@ struct registry_priv
> > #define BSSID_SZ(field) sizeof(((struct wlan_bssid_ex *) 0)->field)
> >
> > #include <drv_types_sdio.h>
> > -#define INTF_DATA SDIO_DATA
> > +#define INTF_DATA struct sdio_data
> >
>
> Just get rid of INTF_DATA data as well. It's only used once a bit lower
> in the file. (Get rid of the ifdef around it).

But, reference of INTF_DATA is also included in file
./drivers/staging/rtl8723bs/include/drv_types.h:487:
return &dvobj->intf_data.func->dev;

thanks for the review
madhumitha


>
> regards,
> dan carpenter
>
>
>

\
 
 \ /
  Last update: 2019-04-10 21:50    [W:0.115 / U:20.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site