lkml.org 
[lkml]   [2019]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 12/14] x86/watchdog/hardlockup/hpet: Determine if HPET timer caused NMI
On Wed, Apr 10, 2019 at 09:01:52AM +0200, Peter Zijlstra wrote:
> On Tue, Apr 09, 2019 at 06:19:57PM -0700, Ricardo Neri wrote:
> > On Tue, Apr 09, 2019 at 01:28:17PM +0200, Peter Zijlstra wrote:
> > > > @@ -147,6 +161,14 @@ static void set_periodic(struct hpet_hld_data *hdata)
> > > > */
> > > > static bool is_hpet_wdt_interrupt(struct hpet_hld_data *hdata)
> > > > {
> > > > + if (smp_processor_id() == hdata->handling_cpu) {
> > > > + unsigned long tsc_curr;
> > >
> > > TSC is u64
> >
> > In x86_64, isn't u64 an unsigned long? Do you mean to consider the
> > 32-bit case?
>
> Unless none of this code is available for x86_32, you pretty much have
> to consider 32bit.
>
> But even then, using u64 for 64bit values is the right thing.

OK, I'll implement this change.

Thanks and BR,
Ricardo

\
 
 \ /
  Last update: 2019-04-11 03:14    [W:0.097 / U:0.236 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site