[lkml]   [2019]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 0/2] mm/memcontrol: Finer-grained memory control
Hi Waiman,

Waiman Long writes:
>The current control mechanism for memory cgroup v2 lumps all the memory
>together irrespective of the type of memory objects. However, there
>are cases where users may have more concern about one type of memory
>usage than the others.

I have concerns about this implementation, and the overall idea in general. We
had per-class memory limiting in the cgroup v1 API, and it ended up really
poorly, and resulted in a situation where it's really hard to compose a usable
system out of it any more.

A major part of the restructure in cgroup v2 has been to simplify things so
that it's more easy to understand for service owners and sysadmins. This was
intentional, because otherwise the system overall is hard to make into
something that does what users *really* want, and users end up with a lot of
confusion, misconfiguration, and generally an inability to produce a coherent
system, because we've made things too hard to piece together.

In general, for purposes of resource control, I'm not convinced that it makes
sense to limit only one kind of memory based on prior experience with v1. Can
you give a production use case where this would be a clear benefit, traded off
against the increase in complexity to the API?

>For simplicity, the limit is not hierarchical and applies to only tasks
>in the local memory cgroup.

We've made an explicit effort to make all things hierarchical -- this confuses
things further. Even if we did have something like this, it would have to
respect the hierarchy, we really don't want to return to the use_hierarchy
days where users, sysadmins, and even ourselves are confused by the resource
control semantics that are supposed to be achieved.

>We have customer request to limit memory consumption on anonymous memory
>only as they said the feature was available in other OSes like Solaris.

What's the production use case where this is demonstrably providing clear
benefits in terms of resource control? How can it compose as part of an easy to
understand, resource controlling system? I'd like to see a lot more information
on why this is needed, and the usability and technical tradeoffs considered.



 \ /
  Last update: 2019-04-10 23:38    [W:0.111 / U:6.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site