lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG/PATCH 1/4] DTS: GTA04: SPI / gpiolib: work around a regression that unhides a broken legacy handler, which makes the gta04 display inoperable
Hi,

* H. Nikolaus Schaller <hns@goldelico.com> [190331 10:08]:
> This is an ugly workaround for a regression introduced into v5.1-rc1 by
>
> <c1c04cea13dc234ce9a4504879ddd36ea524d880>

You should standardized commit references like this instead:

c1c04cea13dc ("gpio: of: Fix logic inversion")

Then please also include a proper Fixes tag.

You can configure an alias for it to make things easier:

git log --abbrev=12 --pretty=format:"%h (\"%s\")"

> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> @@ -114,6 +114,7 @@
> gpio-miso = <&gpio1 18 GPIO_ACTIVE_HIGH>;
> gpio-mosi = <&gpio1 20 GPIO_ACTIVE_HIGH>;
> cs-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
> + spi-cs-high; /* make the legacy handler in gpiolib not intervene */
> num-chipselects = <1>;
>
> /* lcd panel */
> @@ -123,6 +124,7 @@
> spi-max-frequency = <100000>;
> spi-cpol;
> spi-cpha;
> + spi-cs-high; /* here is where it should be but this is ignored by a bug in the gpiolib handler */
>
> backlight= <&backlight>;
> label = "lcd";

So what's the plan with this fix? Add this for v5.2-rc cycle,
then revert it later? I'd probably go directly for the proper
fix if possible.

Regards,

Tony

\
 
 \ /
  Last update: 2019-04-01 18:47    [W:0.094 / U:2.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site