lkml.org 
[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/7] fbdev: sm712fb: add 2D-related I/O headers and functions.
On Sun, Mar 31, 2019 at 06:25:58PM +0100, Sudip Mukherjee wrote:
> On Fri, Mar 22, 2019 at 01:17:54PM +0800, Yifeng Li wrote:
> > +#define DE_CTRL_COMMAND_SHIFT 16
> > +#define DE_CTRL_COMMAND_BITBLT 0x00
> > +#define DE_CTRL_COMMAND_SOLIDFILL 0x01
> > +#define DE_CTRL_COMMAND_HOSTWRITE 0x08
> > +#define DE_CTRL_ROP2_SELECT 0x00008000
> > +#define DE_CTRL_ROP2_SRC_IS_PATTERN 0x00004000
> > +#define DE_CTRL_ROP2_SHIFT 0
> > +#define DE_CTRL_ROP2_COPY 0x0c
> > +#define DE_CTRL_HOST_SHIFT 22
> > +#define DE_CTRL_HOST_SRC_IS_MONO 0x01
> > +#define DE_CTRL_FORMAT_XY 0x00
> > +#define DE_CTRL_FORMAT_24BIT 0x30
>
> Please fix the alignment. Some of them are right aligned and some are left.

Noted. It will be fixed in PATCH v3.

Thanks,
Tom Li

\
 
 \ /
  Last update: 2019-04-01 18:04    [W:0.070 / U:22.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site