[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 5.0 106/146] drm/vgem: fix use-after-free when drm_gem_handle_create() fails
5.0-stable review patch.  If anyone has any objections, please let me know.


From: Eric Biggers <>

commit 21d2b122732318b48c10b7262e15595ce54511d3 upstream.

If drm_gem_handle_create() fails in vgem_gem_create(), then the
drm_vgem_gem_object is freed twice: once when the reference is dropped
by drm_gem_object_put_unlocked(), and again by __vgem_gem_destroy().

This was hit by syzkaller using fault injection.

Fix it by skipping the second free.

Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces")
Reviewed-by: Chris Wilson <>
Cc: Laura Abbott <>
Cc: Daniel Vetter <>
Signed-off-by: Eric Biggers <>
Acked-by: Laura Abbott <>
Signed-off-by: Rodrigo Siqueira <>
Signed-off-by: Maxime Ripard <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/gpu/drm/vgem/vgem_drv.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -191,13 +191,9 @@ static struct drm_gem_object *vgem_gem_c
ret = drm_gem_handle_create(file, &obj->base, handle);
if (ret)
- goto err;
+ return ERR_PTR(ret);

return &obj->base;
- __vgem_gem_destroy(obj);
- return ERR_PTR(ret);

static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev,

 \ /
  Last update: 2019-04-01 20:09    [W:0.370 / U:8.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site