[lkml]   [2019]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.19 098/134] drm/vkms: fix use-after-free when drm_gem_handle_create() fails
4.19-stable review patch.  If anyone has any objections, please let me know.


From: Eric Biggers <>

commit 36b6c9ed45afe89045973e8dee1b004dd5372d40 upstream.

If drm_gem_handle_create() fails in vkms_gem_create(), then the
vkms_gem_object is freed twice: once when the reference is dropped by
drm_gem_object_put_unlocked(), and again by the extra calls to
drm_gem_object_release() and kfree().

Fix it by skipping the second release and free.

This bug was originally found in the vgem driver by syzkaller using
fault injection, but I noticed it's also present in the vkms driver.

Fixes: 559e50fd34d1 ("drm/vkms: Add dumb operations")
Cc: Rodrigo Siqueira <>
Cc: Haneen Mohammed <>
Cc: Daniel Vetter <>
Cc: Chris Wilson <>
Signed-off-by: Eric Biggers <>
Reviewed-by: Chris Wilson <>
Reviewed-by: Rodrigo Siqueira <>
Signed-off-by: Rodrigo Siqueira <>
Signed-off-by: Maxime Ripard <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/gpu/drm/vkms/vkms_gem.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/gpu/drm/vkms/vkms_gem.c
+++ b/drivers/gpu/drm/vkms/vkms_gem.c
@@ -110,11 +110,8 @@ struct drm_gem_object *vkms_gem_create(s

ret = drm_gem_handle_create(file, &obj->gem, handle);
- if (ret) {
- drm_gem_object_release(&obj->gem);
- kfree(obj);
+ if (ret)
return ERR_PTR(ret);
- }

return &obj->gem;

 \ /
  Last update: 2019-04-01 20:01    [W:0.359 / U:12.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site