[lkml]   [2019]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 01/15] perf tools: Add utility function to fetch executable
> . No need to cast around, make 'buf' be a void pointer
> . Rename it to thread__memcpy() to reflect the fact it is about copying
> a chunk of memory from a thread, i.e. from its address space.
> . No need to have it in a separate object file, move it to thread.[ch]
> . Check the return of map__load(), the original code didn't do it, but
> since we're moving this around, check that as well, could be moved to
> a separate patch tho.

Changes look good. Thanks Arnaldo.


 \ /
  Last update: 2019-03-06 22:12    [W:0.084 / U:5.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site