lkml.org 
[lkml]   [2019]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/CPU: Use correct macros for Cyrix calls on Geode processors
Matthew,

On Wed, 6 Mar 2019, Matthew Whitehead wrote:

> There are comments in processor-cyrix.h advising you to _not_ make calls
> using the deprecated macros in this style:
>
> setCx86_old(CX86_CCR4, getCx86_old(CX86_CCR4) | 0x80);
>
> This is because it expands the macro into a non-functioning calling
> sequence. The calling order must be:
>
> outb(CX86_CCR2, 0x22);
> inb(0x23);
>
> >From the comments:
>
> * When using the old macros a line like
> * setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88);
> * gets expanded to:
> * do {
> * outb((CX86_CCR2), 0x22);
> * outb((({
> * outb((CX86_CCR2), 0x22);
> * inb(0x23);
> * }) | 0x88), 0x23);
> * } while (0);
>
> The new macros fix this problem, so use them instead. Tested on an
> actual Geode processor.

Thanks for cleaning that up, but now the old macros are unused, so please
remove them entirely including the comment.

Thanks,

tglx

\
 
 \ /
  Last update: 2019-03-06 21:11    [W:0.035 / U:0.208 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site