lkml.org 
[lkml]   [2019]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/unwind/orc: Fix ORC unwind table alignment
On Wed, Mar 06, 2019 at 10:44:01AM -0800, Nick Desaulniers wrote:
> On Wed, Mar 6, 2019 at 9:08 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> >
> > The .orc_unwind section is a packed array of 6-byte structs. It's
> > currently aligned to 6 bytes, which is causing warnings in the LLD
> > linker.
> >
> > Six isn't a power of two, so it's not a valid alignment value. The
> > actual alignment doesn't matter much because it's an array of packed
> > structs. An alignment of two is sufficient. In reality it always gets
> > aligned to four bytes because it comes immediately after the
> > 4-byte-aligned .orc_unwind_ip section.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/218
> > Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
>
> Thanks for the patch Josh, we appreciate it. It looks like
> ee9f8fce9964 landed in v4.14-rc1. Should we CC stable?

Yes, that would be a good idea.

Can the tip maintainers please add

Cc: stable@vger.kernel.org

when merging?

--
Josh

\
 
 \ /
  Last update: 2019-03-06 20:07    [W:0.061 / U:4.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site