lkml.org 
[lkml]   [2019]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] scsi: NCR5380: Mark expected switch fall-through
From
Date

Hi Finn,

Please submit this as a formal patch. Thanks!

> Here's an alternative patch, which has the virtue that a simple heuristic
> will work. This patch does not require that other static analysis tools
> will follow gcc's weird rules about hyphens. (I assume they don't but I
> didn't check.)
>
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index 7fed9bb72784..fe0535affc14 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1932,13 +1932,13 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
> if (!hostdata->connected)
> return;
>
> - /* Fall through to reject message */
> -
> + /* Reject message */
> + /* Fall through */
> + default:
> /*
> * If we get something weird that we aren't expecting,
> - * reject it.
> + * log it.
> */
> - default:
> if (tmp == EXTENDED_MESSAGE)
> scmd_printk(KERN_INFO, cmd,
> "rejecting unknown extended message code %02x, length %d\n",

--
Martin K. Petersen Oracle Linux Engineering

\
 
 \ /
  Last update: 2019-03-06 18:40    [W:0.076 / U:0.480 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site