lkml.org 
[lkml]   [2019]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: watchdog: Kconfig: pedantic cleanups
From
Date
On 3/6/19 7:15 AM, Enrico Weigelt, metux IT consult wrote:
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>


Checkpatch says:

WARNING: Missing commit description - Add an appropriate one

There needs to be some kind of description of those pedantic cleanups.

On top of that, while the affected Kconfig file generates 42 checkpatch
warnings, this patch doesn't fix a single one of them. I don't really
see the point of this patch.

Thanks,
Guenter

> ---
> drivers/watchdog/Kconfig | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 57f017d..38509d5 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG
> select MFD_SYSCON
> select WATCHDOG_CORE
> help
> - Say Y here to include support for the watchdog timer found on
> - Marvell Armada 37xx SoCs.
> - To compile this driver as a module, choose M here: the
> - module will be called armada_37xx_wdt.
> + Say Y here to include support for the watchdog timer found on
> + Marvell Armada 37xx SoCs.
> + To compile this driver as a module, choose M here: the
> + module will be called armada_37xx_wdt.
>
> config ASM9260_WATCHDOG
> tristate "Alphascale ASM9260 watchdog"
> @@ -606,10 +606,10 @@ config MAX77620_WATCHDOG
> tristate "Maxim Max77620 Watchdog Timer"
> depends on MFD_MAX77620 || COMPILE_TEST
> help
> - This is the driver for the Max77620 watchdog timer.
> - Say 'Y' here to enable the watchdog timer support for
> - MAX77620 chips. To compile this driver as a module,
> - choose M here: the module will be called max77620_wdt.
> + This is the driver for the Max77620 watchdog timer.
> + Say 'Y' here to enable the watchdog timer support for
> + MAX77620 chips. To compile this driver as a module,
> + choose M here: the module will be called max77620_wdt.
>
> config IMX2_WDT
> tristate "IMX2+ Watchdog"
> @@ -1632,10 +1632,10 @@ config BCM7038_WDT
> depends on HAS_IOMEM
> depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> help
> - Watchdog driver for the built-in hardware in Broadcom 7038 and
> - later SoCs used in set-top boxes. BCM7038 was made public
> - during the 2004 CES, and since then, many Broadcom chips use this
> - watchdog block, including some cable modem chips.
> + Watchdog driver for the built-in hardware in Broadcom 7038 and
> + later SoCs used in set-top boxes. BCM7038 was made public
> + during the 2004 CES, and since then, many Broadcom chips use this
> + watchdog block, including some cable modem chips.
>
> config IMGPDC_WDT
> tristate "Imagination Technologies PDC Watchdog Timer"
>

\
 
 \ /
  Last update: 2019-03-06 17:16    [W:0.058 / U:1.344 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site