lkml.org 
[lkml]   [2019]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ipc: Fix building compat mode without sysvipc
From
Date
On 3/6/19 6:29 AM, Arnd Bergmann wrote:
> As John Stultz noticed, my y2038 syscall series caused a link
> failure when CONFIG_SYSVIPC is enabled but CONFIG_COMPAT is
> enabled:
>

is this supposed to be "CONFIG_SYSVIPC is disabled" to match the
subject?

> arch/arm64/kernel/sys32.o:(.rodata+0x960): undefined reference to `__arm64_compat_sys_old_semctl'
> arch/arm64/kernel/sys32.o:(.rodata+0x980): undefined reference to `__arm64_compat_sys_old_msgctl'
> arch/arm64/kernel/sys32.o:(.rodata+0x9a0): undefined reference to `__arm64_compat_sys_old_shmctl'
>
> Add the missing entries in kernel/sys_ni.c for the new system
> calls.
>
> Cc: Laura Abbott <labbott@redhat.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I'm about to send off my pull requests for arm-soc, so I'd just
> send another one with just this common from my y2038 tree.
> ---
> kernel/sys_ni.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index 85e5ccec0955..62a6c8707799 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -202,6 +202,7 @@ COND_SYSCALL(msgget);
> COND_SYSCALL(old_msgctl);
> COND_SYSCALL(msgctl);
> COND_SYSCALL_COMPAT(msgctl);
> +COND_SYSCALL_COMPAT(old_msgctl);
> COND_SYSCALL(msgrcv);
> COND_SYSCALL_COMPAT(msgrcv);
> COND_SYSCALL(msgsnd);
> @@ -212,6 +213,7 @@ COND_SYSCALL(semget);
> COND_SYSCALL(old_semctl);
> COND_SYSCALL(semctl);
> COND_SYSCALL_COMPAT(semctl);
> +COND_SYSCALL_COMPAT(old_semctl);
> COND_SYSCALL(semtimedop);
> COND_SYSCALL(semtimedop_time32);
> COND_SYSCALL(semop);
> @@ -221,6 +223,7 @@ COND_SYSCALL(shmget);
> COND_SYSCALL(old_shmctl);
> COND_SYSCALL(shmctl);
> COND_SYSCALL_COMPAT(shmctl);
> +COND_SYSCALL_COMPAT(old_shmctl);
> COND_SYSCALL(shmat);
> COND_SYSCALL_COMPAT(shmat);
> COND_SYSCALL(shmdt);
>

\
 
 \ /
  Last update: 2019-03-06 15:45    [W:0.047 / U:0.836 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site