[lkml]   [2019]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm
On Mon, Mar 04, 2019 at 08:19:14PM -0500, Su Yanjun wrote:
> For rcu protected pointers, we'd better add '__rcu' for them.
> Once added '__rcu' tag for rcu protected pointer, the sparse tool reports
> warnings.
> net/xfrm/xfrm_user.c:1198:39: sparse: expected struct sock *sk
> net/xfrm/xfrm_user.c:1198:39: sparse: got struct sock [noderef] <asn:4> *nlsk
> [...]
> So introduce a new wrapper function of nlmsg_unicast to handle type
> conversions.
> No functional change.

While that was true for v1 of that patch, it is not
true for this version. This fixes a direct access
of a rcu protected socket. So please add a proper
'Fixes' tag.

 \ /
  Last update: 2019-03-06 12:34    [W:0.029 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site