lkml.org 
[lkml]   [2019]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH][next] net/mlx5e: Remove redundant assignment
Date


On 02/03/2019 21:39, Gustavo A. R. Silva wrote:
> Remove redundant assignment to tun_entropy->enabled.
>
> Addesses-Coverity-ID: 1477328 ("Unused value")
> Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation")

the commit doesn't fix any real issue but is more of a cleanup.
so I'm not sure if fixes line is relevant or not.
beside that looks ok.

Reviewed-by: Roi Dayan <roid@mellanox.com>


> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> index 40f4a19b1ce1..be69c1d7941a 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct mlx5_tun_entropy *tun_entropy,
> mlx5_query_port_tun_entropy(mdev, &entropy_flags);
> tun_entropy->num_enabling_entries = 0;
> tun_entropy->num_disabling_entries = 0;
> - tun_entropy->enabled = entropy_flags.calc_enabled;
> - tun_entropy->enabled =
> - (entropy_flags.calc_supported) ?
> - entropy_flags.calc_enabled : true;
> + tun_entropy->enabled = entropy_flags.calc_supported ?
> + entropy_flags.calc_enabled : true;
> }
>
> static int mlx5_set_entropy(struct mlx5_tun_entropy *tun_entropy,
>
\
 
 \ /
  Last update: 2019-03-03 16:21    [W:0.102 / U:6.440 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site