[lkml]   [2019]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net-next v2] net: dsa: Use prepare/commit phase in dsa_slave_vlan_rx_add_vid()
From: Florian Fainelli <>
Date: Fri, 1 Mar 2019 10:37:25 -0800

> We were skipping the prepare phase which causes some problems with at
> least a couple of drivers:
> - mv88e6xxx chooses to skip programming VID = 0 with -EOPNOTSUPP in
> the prepare phase, but we would still try to force this VID since we
> would only call the commit phase and so we would get the driver to
> return -EINVAL instead
> - qca8k does not currently have a port_vlan_add() callback implemented,
> yet we would try to call that unconditionally leading to a NPD
> Fix both issues by conforming to the current model doing a
> prepare/commit phase, this makes us consistent throughout the code and
> assumptions.
> Reported-by: Heiner Kallweit <>
> Reported-by: Michal Vokáč <>
> Fixes: 061f6a505ac3 ("net: dsa: Add ndo_vlan_rx_{add, kill}_vid implementation")
> Signed-off-by: Florian Fainelli <>

Applied, thanks Florian.

 \ /
  Last update: 2019-03-04 05:46    [W:0.056 / U:6.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site