lkml.org 
[lkml]   [2019]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon
From
Date
Hi Andy,

On 2019/3/2 23:56, Andy Shevchenko wrote:
> On Sat, Mar 2, 2019 at 11:06 AM Yu Chen <chenyu56@huawei.com> wrote:
>>
>> This driver handles usb phy power on and shutdown for hi3660 Soc of
>> Hisilicon.
>
> Few comments below. After fixing them, FWIW
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
>> +#define HI3660_USB_DEFAULT_PHY_PARAM 0x1c466e3
>
> A bit of description would be nice to have what this value means.
>
OK.
>> + /* delay for exit from IDDQ mode */
>> + usleep_range(100, 100);
>
> 100,100 ? I think you need to give a room to scheduler, at least 20%
> margin would be good to have.
>
>> + /* delay for vbus valid */
>> + usleep_range(100, 100);
>
> Ditto.
>
>
OK.

Thanks
Yu Chen

\
 
 \ /
  Last update: 2019-03-04 03:38    [W:0.074 / U:0.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site