lkml.org 
[lkml]   [2019]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro
On Wed, Mar 27, 2019 at 02:33:14PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote:
> > Replace verbose implementation in set_multiple callback with
> > for_each_set_clump8 macro to simplify code and improve clarity.
>
> > + for_each_set_clump8(offset, bankmask, mask, chip->registers * 8) {
>
> > + bank = (chip->registers - 1) - (offset / 8);
>
> Excessive parens, but it's minor.

Fair point, this could do without parens around (chip->registers - 1).

Since this and renaming 'idx' to 'index' in find_bit.c are such a minor
changes, I'll wait first to see if something else comes up to be fixed
in this review. If so, I'll add these changes to the next version of
this patchset.

William Breathitt Gray

>
> > + bitmask = bitmap_get_value8(bits, offset) & bankmask;
> >
> > chip->buffer[bank] &= ~bankmask;
> > + chip->buffer[bank] |= bitmask;
> > }
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

\
 
 \ /
  Last update: 2019-03-28 05:40    [W:0.090 / U:3.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site