lkml.org 
[lkml]   [2019]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: renesas-ceu: fix a potential NULL pointer dereference
From
Date
On 3/9/19 8:14 AM, Kangjie Lu wrote:
> In case of_match_device cannot find a match, the check returns
> -EINVAL to avoid a potential NULL pointer dereference
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/media/platform/renesas-ceu.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c
> index 150196f7cf96..4aa807c0b6c7 100644
> --- a/drivers/media/platform/renesas-ceu.c
> +++ b/drivers/media/platform/renesas-ceu.c
> @@ -1682,7 +1682,10 @@ static int ceu_probe(struct platform_device *pdev)
>
> if (IS_ENABLED(CONFIG_OF) && dev->of_node) {
> ceu_data = of_match_device(ceu_of_match, dev)->data;
> - num_subdevs = ceu_parse_dt(ceudev);

A far as I can tell ceu_parse_dt will never return 0.

I'm dropping this patch.

Regards,

Hans

> + if (unlikely(!ceu_data))
> + num_subdevs = -EINVAL;
> + else
> + num_subdevs = ceu_parse_dt(ceudev);
> } else if (dev->platform_data) {
> /* Assume SH4 if booting with platform data. */
> ceu_data = &ceu_data_sh4;
>

\
 
 \ /
  Last update: 2019-03-28 16:31    [W:0.033 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site