lkml.org 
[lkml]   [2019]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] gpio: Remove obsolete comment about gpiochip_free_hogs() usage
From
Date

On 3/28/2019 6:43 PM, Geert Uytterhoeven wrote:
> gpiochip_free_hogs() was always called from gpiochip_remove(), not
> of_gpiochip_remove(). It is now also called from the failure patch in
> gpiochip_add_data_with_key().
>
> Fixes: f625d4601759f1cf ("gpio: add GPIO hogging mechanism")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>


Looks good to be removed.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

-Mukesh

> ---
> drivers/gpio/gpiolib.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index ed4da07effe0ac40..ec326bd84b1f1c50 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -4449,8 +4449,6 @@ int gpiod_hog(struct gpio_desc *desc, const char *name,
> /**
> * gpiochip_free_hogs - Scan gpio-controller chip and release GPIO hog
> * @chip: gpio chip to act on
> - *
> - * This is only used by of_gpiochip_remove to free hogged gpios
> */
> static void gpiochip_free_hogs(struct gpio_chip *chip)
> {

\
 
 \ /
  Last update: 2019-03-28 16:03    [W:0.270 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site