[lkml]   [2019]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 2/7] x86/boot: Introduce helpers for serial I/O
On Thu, Mar 28, 2019 at 03:34:47PM +0100, Borislav Petkov wrote:
> On Thu, Mar 28, 2019 at 04:20:01PM +0200, Andy Shevchenko wrote:
> > By name and by what it's handling (only byte accesses to I/O or MMIO).
> Your series does only byte accesses so you can use byte variant.
> > My point is, that doing branch(es) on each I/O call is not good as simple
> > calling the proper (pre-defined) I/O accessor.
> What branches?

Something like this at the end

if (mmio32)
else if (mmio)
else if (whatever)

> You do a branch and *then* you do an IO call.


> What does "not good" even mean?

We still export global flag variable, on top of this we need an additional
branch which we can avoid for free.

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2019-03-28 15:52    [W:0.092 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site