[lkml]   [2019]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper for earlyprintk
On Thu, Mar 28, 2019 at 02:39:07PM +0100, Borislav Petkov wrote:
> On Thu, Mar 28, 2019 at 03:15:57PM +0200, Andy Shevchenko wrote:
> > kstrtox() simple can't cover _all_ simple_strtox() cases.
> I see only one case here. Are you saying kstrtoull() cannot work
> here?

Can, but with code uglifying to workaround kstrtox() restrictions.
simple_strtox() _just works_ as expected.

> > I don't feel like uglifying code to satisfy a tool producing a silly
> warning.
> Uglifying how?

Requires buffer copying, finding digits there, making a proper termination. And
basically dropping the error check, because we don't care at this stage about
wrong input.

And we didn't start to talk about possible user expectation breakage and
basically breakage weird user cases.

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2019-03-28 14:51    [W:0.130 / U:4.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site