lkml.org 
[lkml]   [2019]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper for earlyprintk
On Thu, Mar 28, 2019 at 01:35:04PM +0100, Borislav Petkov wrote:
> On Tue, Mar 19, 2019 at 09:43:21PM +0300, Andy Shevchenko wrote:
> > The newly introduced helper will be used later on to parse serial port
> > in different type of earlyprintk command line arguments.
> >
> > No functional change intended.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > arch/x86/boot/early_serial_console.c | 20 +++++++++++++++-----
> > 1 file changed, 15 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
> > index 05d02cd4de99..85a227a21f95 100644
> > --- a/arch/x86/boot/early_serial_console.c
> > +++ b/arch/x86/boot/early_serial_console.c
> > @@ -66,6 +66,20 @@ static void early_serial_init(unsigned long port, int baud)
> > early_serial_base = port;
> > }
> >
> > +static unsigned long parse_serial_port(const char *arg, int off, int *pos)
> > +{
> > + unsigned long port;
> > + char *e;
> > +
> > + port = simple_strtoull(arg + off, &e, 16);
>
> WARNING: simple_strtoull is obsolete, use kstrtoull instead
> #41: FILE: arch/x86/boot/early_serial_console.c:74:
> + port = simple_strtoull(arg + off, &e, 16);

kstrtox() simple can't cover _all_ simple_strtox() cases.

> Please do a conversion patch ontop.

I don't feel like uglifying code to satisfy a tool producing a silly warning.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-03-28 14:16    [W:0.106 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site