lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/8] i2c: iproc: Extend I2C read up to 255 bytes

> + if (!((readl(iproc_i2c->base +
> + M_FIFO_CTRL_OFFSET) >>
> + M_FIFO_RX_CNT_SHIFT) &
> + M_FIFO_RX_CNT_MASK))

Don't be too strict with the 80 char limit. I think the above is hardly
readable...

> + break;
> +
> + msg->buf[iproc_i2c->rx_bytes] =
> + (readl(iproc_i2c->base + M_RX_OFFSET) >>
> + M_RX_DATA_SHIFT) & M_RX_DATA_MASK;

... this here is MUCH better.

Rest looks good.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-03-27 23:18    [W:0.197 / U:3.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site