lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] drm/ttm: remove set but not used variable 'vgdev'
From
Date
On 2019/3/25 17:02, Daniel Vetter wrote:
> On Wed, Mar 20, 2019 at 02:03:08AM +0000, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type':
>> drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning:
>> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>>
>> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_bo_swap_notify':
>> drivers/gpu/drm/virtio/virtgpu_ttm.c:300:28: warning:
>> variable 'vgdev' set but not used [-Wunused-but-set-variable]
>>
>> It is never used since introduction in dc5698e80cf7 ("Add virtio gpu driver.")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Subject prefix should be drm/virtio: which is maybe the reason Gerd hasn't
> spotted this yet.

Thanks, will fix it.

> -Daniel
>
>> ---
>> drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c
>> index d6225ba20b30..eb007c2569d8 100644
>> --- a/drivers/gpu/drm/virtio/virtgpu_ttm.c
>> +++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c
>> @@ -114,10 +114,6 @@ static const struct ttm_mem_type_manager_func virtio_gpu_bo_manager_func = {
>> static int virtio_gpu_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
>> struct ttm_mem_type_manager *man)
>> {
>> - struct virtio_gpu_device *vgdev;
>> -
>> - vgdev = virtio_gpu_get_vgdev(bdev);
>> -
>> switch (type) {
>> case TTM_PL_SYSTEM:
>> /* System memory */
>> @@ -297,10 +293,8 @@ static void virtio_gpu_bo_move_notify(struct ttm_buffer_object *tbo,
>> static void virtio_gpu_bo_swap_notify(struct ttm_buffer_object *tbo)
>> {
>> struct virtio_gpu_object *bo;
>> - struct virtio_gpu_device *vgdev;
>>
>> bo = container_of(tbo, struct virtio_gpu_object, tbo);
>> - vgdev = (struct virtio_gpu_device *)bo->gem_base.dev->dev_private;
>>
>> if (bo->pages)
>> virtio_gpu_object_free_sg_table(bo);
>>
>>
>>
>

\
 
 \ /
  Last update: 2019-03-25 10:12    [W:0.100 / U:4.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site