lkml.org 
[lkml]   [2019]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] tracing: initialize variable in create_dyn_event()
On Fri, 22 Mar 2019 15:20:00 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 21 Mar 2019 23:58:20 -0700
> frowand.list@gmail.com wrote:
>
> > From: Frank Rowand <frank.rowand@sony.com>
> >
> > Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized
> > in this function [-Wuninitialized].
> >
> > Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework")
> >
> > Signed-off-by: Frank Rowand <frank.rowand@sony.com>
>
> Applied. Thanks Frank!

Thank you Frank and Steve,

feel free to add my ack.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

>
> -- Steve
>
> > ---
> >
> > changes since v1:
> > - initialize to -ENODEV instead of 0, as suggested by Steve
> >
> > kernel/trace/trace_dynevent.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_dynevent.c b/kernel/trace/trace_dynevent.c
> > index dd1f43588d70..fa100ed3b4de 100644
> > --- a/kernel/trace/trace_dynevent.c
> > +++ b/kernel/trace/trace_dynevent.c
> > @@ -74,7 +74,7 @@ int dyn_event_release(int argc, char **argv, struct dyn_event_operations *type)
> > static int create_dyn_event(int argc, char **argv)
> > {
> > struct dyn_event_operations *ops;
> > - int ret;
> > + int ret = -ENODEV;
> >
> > if (argv[0][0] == '-' || argv[0][0] == '!')
> > return dyn_event_release(argc, argv, NULL);
>


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2019-03-23 11:31    [W:0.052 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site