lkml.org 
[lkml]   [2019]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] pinctrl: artpec6: Make two functions static
On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>

> ---
> drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
> index d89dc43..e836850 100644
> --- a/drivers/pinctrl/pinctrl-artpec6.c
> +++ b/drivers/pinctrl/pinctrl-artpec6.c
> @@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
> }
> }
>
> -int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> @@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> return 0;
> }
>
> -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> --
> 2.7.0

/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com

\
 
 \ /
  Last update: 2019-03-21 16:59    [W:0.081 / U:2.640 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site