lkml.org 
[lkml]   [2019]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: dapm: Fix NULL pointer dereference in snd_soc_dapm_new_dai
On Thu, Mar 21, 2019 at 03:41:25PM +0530, Pankaj Bharadiya wrote:

> outfree_kcontrol_news:
> devm_kfree(card->dev, (void *)template.kcontrol_news);
> - snd_soc_dapm_free_kcontrol(card, &private_value,
> - rtd->dai_link->num_params, w_param_text);
> + if (w_param_text)
> + snd_soc_dapm_free_kcontrol(card, &private_value,
> + rtd->dai_link->num_params, w_param_text);

This is very non-obvious - it's not at all clear why we'd need the text
to free controls. If there is an issue here it seems like it'd be
better to make sure that snd_soc_dapm_free_kcontrol() can cope with that
being NULL, that will be clearer and also avoid potential issues with
other callers.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-03-21 13:32    [W:0.069 / U:1.536 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site