lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND][PATCH 2/2] staging: sm750fb: trivial Camel Case removal for setDisplayControl().
On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote:
> Rename the function setDisplayControl() to set_display_control().
> This fixes the following checkpatch.pl warning:
>
> CHECK: Avoid CamelCase: <setDisplayControl>
>
> Suggested-by: Jin Chen <nobijinc@gmail.com>
> Signed-off-by: Jin Chen <nobijinc@gmail.com>
> [tomli@tomli.me: resent as trivial patch, reworded the commit message]
> Signed-off-by: Yifeng Li <tomli@tomli.me>
> ---

Apparently Greg already applied this earlier... I don't know why the
original patch didn't reach me. I'm on the devel@driverdev.osuosl.org
list.

Did Jin Chen write this? If so why does it have a Suggested-by tag for
him? If not then you should have preserved the authorship credit by
using the From: header in the first line on the commit message...

Anyway, it doesn't matter but hopefully this helps for next time.

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-03-20 13:37    [W:0.082 / U:13.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site