lkml.org 
[lkml]   [2019]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/10] staging: rtl8723bs: Remove unreachable Code in core/rtw_cmd.c
On Sun, Mar 17, 2019 at 07:31:08PM +0100, Emanuel Bennici wrote:
> The `case INTEl_WIDI_WK_CID`-Statement in Function `u8 rtw_drvextra_cmd_hdl`
> wouldn't be used because of CONFIG_INTEL_WIDI.
>
> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 91520ca3bbad..6c6ddf461590 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -2007,11 +2007,6 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
> case CHECK_HIQ_WK_CID:
> rtw_chk_hi_queue_hdl(padapter);
> break;
> -#ifdef CONFIG_INTEL_WIDI
> - case INTEl_WIDI_WK_CID:
> - intel_widi_wk_hdl(padapter, pdrvextra_cmd->type, pdrvextra_cmd->pbuf);
> - break;
> -#endif /* CONFIG_INTEL_WIDI */

Could you just remove all the CONFIG_INTEL_WIDI at once? That would be
easier to review.

(I don't know where the other patches from this series are. Maybe gmail
ate them).

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-03-19 10:33    [W:0.059 / U:2.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site