[lkml]   [2019]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 4/6] leds: netdev trigger: move name length checking to netdev_trig_set_device
On Thu 2019-03-14 15:06:17, Rasmus Villemoes wrote:
> It's better to check that size is sane in the function that does the
> memcpy'ing and 0-termination to the IFNAMSIZ-sized buffer instead of
> relying on callers getting it right. Not rejecting size upfront does
> mean we would do the cancel_delayed_work_sync(), but that gets fixed
> up by the set_baseline_state() call.
> Signed-off-by: Rasmus Villemoes <>

Exactly. 2,4:

Acked-by: Pavel Machek <>

(cesky, pictures)
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2019-03-18 12:26    [W:0.101 / U:9.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site