lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: initialize variable in create_dyn_event()
On Thu, 14 Mar 2019 14:05:02 -0700
Frank Rowand <frowand.list@gmail.com> wrote:

> Hi Steve,
>
> Ping.

Thanks, this got buried.

> > static int create_dyn_event(int argc, char **argv)
> > {
> > struct dyn_event_operations *ops;
> > - int ret;
> > + int ret = 0;

Probably should be ret = -ENODEV;

As if ret doesn't get set, then no dynamic code has been registered,
and something is truly wrong.

-- Steve


> >
> > if (argv[0][0] == '-' || argv[0][0] == '!')
> > return dyn_event_release(argc, argv, NULL);
> >

\
 
 \ /
  Last update: 2019-03-14 23:19    [W:0.081 / U:17.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site