lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] firewire: mark expected switch fall-throughs
From
Date


On 3/14/19 5:00 AM, Stefan Richter wrote:

[..]

>> diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c
>> index 35e784cffc23..7e5c98840b80 100644
>> --- a/drivers/firewire/core-iso.c
>> +++ b/drivers/firewire/core-iso.c
>> @@ -308,7 +308,7 @@ static int manage_channel(struct fw_card *card, int irm_id, int generation,
>> if ((data[0] & bit) == (data[1] & bit))
>> continue;
>>
>> - /* 1394-1995 IRM, fall through to retry. */
>> + /* fall through - to retry for 1394-1995 IRM */
>
> If you don't mind, I will apply your patch with a different wording of this
> comment:
>
> /* fall through - It's an 1394-1995 IRM, retry. */
>
> I'll mark my modification to your patch in the signed-off-by-tag.
>

Sure. That's fine with me.

Thank you.
--
Gustavo

\
 
 \ /
  Last update: 2019-03-14 19:43    [W:0.076 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site