lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/v3d: Use the new shmem helpers to reduce driver boilerplate.
On Thu, Mar 14, 2019 at 11:34 AM Eric Anholt <eric@anholt.net> wrote:
>
> The new shmem helpers from Noralf and Rob abstract out a bunch of our
> BO creation and mapping code.
>
> v2: Use the new sgt getter, and flag pages as dirty before freeing.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> drivers/gpu/drm/v3d/Kconfig | 1 +
> drivers/gpu/drm/v3d/v3d_bo.c | 317 ++++++++++------------------------
> drivers/gpu/drm/v3d/v3d_drv.c | 27 +--
> drivers/gpu/drm/v3d/v3d_drv.h | 14 +-
> drivers/gpu/drm/v3d/v3d_gem.c | 12 +-
> drivers/gpu/drm/v3d/v3d_irq.c | 8 +-
> drivers/gpu/drm/v3d/v3d_mmu.c | 11 +-
> 7 files changed, 120 insertions(+), 270 deletions(-)

> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
> index 945eaaaad016..b84d89c7b3fb 100644
> --- a/drivers/gpu/drm/v3d/v3d_gem.c
> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
> @@ -201,7 +201,8 @@ v3d_attach_object_fences(struct v3d_bo **bos, int bo_count,
>
> for (i = 0; i < bo_count; i++) {
> /* XXX: Use shared fences for read-only objects. */
> - reservation_object_add_excl_fence(bos[i]->base.resv, fence);
> + reservation_object_add_excl_fence(bos[i]->base.base.resv,
> + fence);

All these 'bos[i]->base.base' occurrences are not the prettiest.
Changing your bos array to a struct drm_gem_object ** instead would
help. That's what I did for panfrost. Though I've not looked at were
you actually need the v3d_bo.

Either way,

Reviewed-by: Rob Herring <robh@kernel.org>

Rob

\
 
 \ /
  Last update: 2019-03-14 19:16    [W:0.089 / U:26.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site