lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set
On Wed, Mar 13, 2019 at 04:11:55PM -0700, Paul E. McKenney wrote:
> commit 34f67df09cc0c6bf082a7cfca435373caeeb8d82
> Author: Paul E. McKenney <paulmck@linux.ibm.com>
> Date: Wed Mar 13 16:06:22 2019 -0700
>
> srcu: Forbid DEFINE{,_STATIC}_SRCU() from modules
>
> Adding DEFINE_SRCU() or DEFINE_STATIC_SRCU() to a loadable module
> requires that the size of the reserved region be increased, which is
> not something we want to be doing all that often. Instead, loadable
> modules should define an srcu_struct and invoke init_srcu_struct()
> from their module_init function and cleanup_srcu_struct() from their
> module_exit function. Note that modules using call_srcu() will also
> need to invoke srcu_barrier() from their module_exit function.
>
> This commit enforces this advice by refusing to define DEFINE_SRCU()
> and DEFINE_STATIC_SRCU() within loadable modules.
>
> Suggested-by: Barret Rhoden <brho@google.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>

Looks-great-to-me-by: Tejun Heo <tj@kernel.org>

Thanks. :)

--
tejun

\
 
 \ /
  Last update: 2019-03-14 18:37    [W:0.057 / U:61.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site