lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] objtool: Move objtool_file struct off the stack
Date
Josh Poimboeuf <jpoimboe@redhat.com> writes:

> Objtool uses over 512k of stack, thanks to the hash table embedded in
> the objtool_file struct. This causes an unnecessarily large stack
> allocation and breaks users with low stack limits.
>
> Move the struct off the stack.
>
> Fixes: 042ba73fe7eb ("objtool: Add several performance improvements")
> Reported-by: Vassili Karpov <moosotc@gmail.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
> tools/objtool/check.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 0414a0d52262..91c4799192e1 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -2184,9 +2184,10 @@ static void cleanup(struct objtool_file *file)
> elf_close(file->elf);
> }
>
> +struct objtool_file file;
> +

Maybe it also deserves a "static" storage duration (if nothing else this
would prevent possible name clashes)?

> int check(const char *_objname, bool orc)
> {
> - struct objtool_file file;
> int ret, warnings = 0;
>
> objname = _objname;

--
mailto:moosotc@gmail.com

\
 
 \ /
  Last update: 2019-03-14 16:32    [W:0.067 / U:6.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site