lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 00/14] Add support for FM radio in hcill and kill TI_ST
On Thu, Mar 14, 2019 at 3:21 AM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> Hi Sebastian,
>
> On 12/21/18 2:17 AM, Sebastian Reichel wrote:
> > Hi,
> >
> > This moves all remaining users of the legacy TI_ST driver to hcill (patches
> > 1-3). Then patches 4-7 convert wl128x-radio driver to a standard platform
> > device driver with support for multiple instances. Patch 7 will result in
> > (userless) TI_ST driver no longer supporting radio at runtime. Patch 8-11 do
> > some cleanups in the wl128x-radio driver. Finally patch 12 removes the TI_ST
> > specific parts from wl128x-radio and adds the required infrastructure to use it
> > with the serdev hcill driver instead. The remaining patches 13 and 14 remove
> > the old TI_ST code.
> >
> > The new code has been tested on the Motorola Droid 4. For testing the audio
> > should be configured to route Ext to Speaker or Headphone. Then you need to
> > plug headphone, since its cable is used as antenna. For testing there is a
> > 'radio' utility packages in Debian. When you start the utility you need to
> > specify a frequency, since initial get_frequency returns an error:
>
> What is the status of this series?
>
> Based on some of the replies (from Adam Ford in particular) it appears that
> this isn't ready to be merged, so is a v2 planned?

If you can leave the Logic PD Torpedo board alone and don't remove the
legacy st driver for now, go ahead and migrate the others. I know
what you proposed 'should' work on my board, but I don't know why it
doesn't. In fact other boards I maintain use your method, but it just
doesn't work on the Torpedo and I don't know why. (it's not for lack
of trying)

adam
>
> Regards,
>
> Hans
>
> >
> > $ radio -f 100.0
> >
> > Merry Christmas!
> >
> > -- Sebastian
> >
> > Sebastian Reichel (14):
> > ARM: dts: LogicPD Torpedo: Add WiLink UART node
> > ARM: dts: IGEP: Add WiLink UART node
> > ARM: OMAP2+: pdata-quirks: drop TI_ST/KIM support
> > media: wl128x-radio: remove module version
> > media: wl128x-radio: remove global radio_disconnected
> > media: wl128x-radio: remove global radio_dev
> > media: wl128x-radio: convert to platform device
> > media: wl128x-radio: use device managed memory allocation
> > media: wl128x-radio: load firmware from ti-connectivity/
> > media: wl128x-radio: simplify fmc_prepare/fmc_release
> > media: wl128x-radio: fix skb debug printing
> > media: wl128x-radio: move from TI_ST to hci_ll driver
> > Bluetooth: btwilink: drop superseded driver
> > misc: ti-st: Drop superseded driver
> >
> > .../boot/dts/logicpd-torpedo-37xx-devkit.dts | 8 +
> > arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 8 +
> > arch/arm/boot/dts/omap3-igep0030-rev-g.dts | 8 +
> > arch/arm/mach-omap2/pdata-quirks.c | 52 -
> > drivers/bluetooth/Kconfig | 11 -
> > drivers/bluetooth/Makefile | 1 -
> > drivers/bluetooth/btwilink.c | 350 -------
> > drivers/bluetooth/hci_ll.c | 115 ++-
> > drivers/media/radio/wl128x/Kconfig | 2 +-
> > drivers/media/radio/wl128x/fmdrv.h | 5 +-
> > drivers/media/radio/wl128x/fmdrv_common.c | 211 ++--
> > drivers/media/radio/wl128x/fmdrv_common.h | 4 +-
> > drivers/media/radio/wl128x/fmdrv_v4l2.c | 55 +-
> > drivers/media/radio/wl128x/fmdrv_v4l2.h | 2 +-
> > drivers/misc/Kconfig | 1 -
> > drivers/misc/Makefile | 1 -
> > drivers/misc/ti-st/Kconfig | 18 -
> > drivers/misc/ti-st/Makefile | 6 -
> > drivers/misc/ti-st/st_core.c | 922 ------------------
> > drivers/misc/ti-st/st_kim.c | 868 -----------------
> > drivers/misc/ti-st/st_ll.c | 169 ----
> > include/linux/ti_wilink_st.h | 337 +------
> > 22 files changed, 213 insertions(+), 2941 deletions(-)
> > delete mode 100644 drivers/bluetooth/btwilink.c
> > delete mode 100644 drivers/misc/ti-st/Kconfig
> > delete mode 100644 drivers/misc/ti-st/Makefile
> > delete mode 100644 drivers/misc/ti-st/st_core.c
> > delete mode 100644 drivers/misc/ti-st/st_kim.c
> > delete mode 100644 drivers/misc/ti-st/st_ll.c
> >
>

\
 
 \ /
  Last update: 2019-03-14 13:20    [W:0.371 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site