lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] x86/tsc: Update cpufreq transition notifier to handle multiple CPUs
On 14-03-19, 10:33, Rafael J. Wysocki wrote:
> On Thu, Mar 14, 2019 at 7:43 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > - set_cyc2ns_scale(tsc_khz, freq->cpu, rdtsc());
> > + if (boot_cpu) {
> > + boot_cpu_data.loops_per_jiffy = lpj;
> > + } else {
> > + for_each_cpu(cpu, freq->cpus)
>
> This needs to iterate over policy->cpus or you change the behavior.
>
> Not that it will matter a lot (x86 in one CPU per policy anyway in the
> vast majority of cases), but it is a change nevertheless. Moreover,
> I'm not even sure if doing that for offline CPUs makes sense.

Okay.

--
viresh

\
 
 \ /
  Last update: 2019-03-14 11:05    [W:0.066 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site