lkml.org 
[lkml]   [2019]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc
Hi!

Could you maybe slow down a bit.

"Hey, I should review this". "Hmm, there are two new versions in the
mailbox in the meantime, good thing I waited."

> + ramp-up-ms = <1024>;
> + ramp-down-ms = <65536>;

This is wrong.

> + led@1 {
> + reg = <1>;
> + led-sources = <1>;
> + ti,led-mode = <0>;
> + label = "keypad";

"platform::kbd_backlight"
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-03-14 10:41    [W:0.148 / U:6.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site