lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 perf,bpf 00/15] perf annotation of BPF programs
On Mon, Mar 11, 2019 at 10:30:36PM -0700, Song Liu wrote:
> Changes v8 to v9:
> 1. Rebase on top of torvalds/master:
> commit ea295481b6e313b4ea3ca2720ffcafd6005b5643 ;
> 2. Change perf-record option --bpf-event to --no-bpf-event.

Reviewed-by: Jiri Olsa <jolsa@kernel.org>

thanks for bearing with me ;-)

jirka


>
> Changes v7 to v8:
> 1. Address issues suggested by Jiri and Stanislav.
>
> Changes v6 to v7:
> 1. Fix minor issues suggested by Jiri.
>
> Changes v5 to v6:
> 1. Improve side band evlist interface;
> 2. Minor style fixes.
>
> Changes v4 to v5:
> 1. Rebase to latest bpf-next;
> 2. Add dependency of 94816add0005 from Arnaldo's tree;
> 3. More details in change logs;
> 4. Add perf_env__init() to init bpf related lock and rbtrees;
> 5. Small clean ups.
>
> Changes v3 to v4:
> 1. Incorporate feedbacks from Jiri and Namhyung;
> 2. Fixed compilation error with different feature-disassembler-four-args;
> 3. Split some patches to smaller patches;
> 4. Improved error handleing in symbol__disassemble_bpf();
> 5. Made side band thread more generic;
> 6. Added comments as suggested.
>
> Changes v2 to v3:
> 1. Remove unnecessary include in header files;
> 2. Improved error handling;
> 3. Better naming of functions, variables, etc.;
> 4. Enable bpf events by default for perf-top.
>
> Changes v1 to v2:
> 1. Fix compilation error with different feature-disassembler-four-args;
> 2. Fix a segfault in perf-record;
> 3. Split patches 5/9 and 6/9 so that perf_env changes and perf.data changes
> are in separate patches.
>
> This series enables annotation of BPF programs in perf.
>
> perf tool gathers information via sys_bpf and (optionally) stores them in
> perf.data as headers.
>
> Patch 1/15 changes --bpf-event option to --no-bpf-event;
> Patch 2/15 to 4/15 introduce new helper functions and use them in perf and
> bpftool;
> Patch 5/15 to 9/15 saves information of bpf program in perf_env;
> Patch 10/15 adds --bpf-event options to perf-top;
> Patch 11/15 to 13/15 enables annotation of bpf progs based on information
> gathered in 5/15 to 9/15;
> Patch 14/15 introduces side band polling thread that gathers information
> for special kernel events during perf-record or perf-top.
> Patch 15/15 handles information of short living BPF program using the new
> side band polling thread.
>
> Commands tested during developments are perf-top, perf-record, perf-report,
> and perf-annotate.
>
> This set is also available at:
>
> https://github.com/liu-song-6/linux/tree/bpf-annotation-v9
>
> Thanks!!
>
> Song Liu (15):
> perf-record: replace option --bpf-event with --no-bpf-event
> bpf: libbpf: introduce bpf_program__get_prog_info_linear()
> bpf: bpftool: use bpf_program__get_prog_info_linear() in
> prog.c:do_dump()
> perf, bpf: synthesize bpf events with
> bpf_program__get_prog_info_linear()
> perf: change prototype of perf_event__synthesize_bpf_events()
> perf, bpf: save bpf_prog_info in a rbtree in perf_env
> perf, bpf: save bpf_prog_info information as headers to perf.data
> perf, bpf: save btf in a rbtree in perf_env
> perf, bpf: save btf information as headers to perf.data
> perf-top: add option --no-bpf-event
> perf: add -lopcodes to feature-libbfd
> perf, bpf: enable annotation of bpf program
> perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation
> perf: introduce side band thread
> perf, bpf: save bpf_prog_info and btf of short living bpf programs
>
> tools/bpf/bpftool/prog.c | 266 +++++++---------------------
> tools/build/Makefile.feature | 6 +-
> tools/lib/bpf/libbpf.c | 251 ++++++++++++++++++++++++++
> tools/lib/bpf/libbpf.h | 63 +++++++
> tools/lib/bpf/libbpf.map | 3 +
> tools/perf/Makefile.config | 10 +-
> tools/perf/builtin-record.c | 11 +-
> tools/perf/builtin-top.c | 10 +-
> tools/perf/perf.c | 1 +
> tools/perf/perf.h | 2 +-
> tools/perf/util/annotate.c | 150 +++++++++++++++-
> tools/perf/util/bpf-event.c | 330 ++++++++++++++++++++++++++---------
> tools/perf/util/bpf-event.h | 33 +++-
> tools/perf/util/dso.c | 1 +
> tools/perf/util/dso.h | 32 ++--
> tools/perf/util/env.c | 151 ++++++++++++++++
> tools/perf/util/env.h | 24 +++
> tools/perf/util/evlist.c | 119 +++++++++++++
> tools/perf/util/evlist.h | 12 ++
> tools/perf/util/evsel.c | 2 +-
> tools/perf/util/evsel.h | 6 +
> tools/perf/util/header.c | 238 ++++++++++++++++++++++++-
> tools/perf/util/header.h | 2 +
> tools/perf/util/session.c | 1 +
> tools/perf/util/symbol.c | 1 +
> 25 files changed, 1409 insertions(+), 316 deletions(-)
>
> --
> 2.17.1

\
 
 \ /
  Last update: 2019-03-12 14:13    [W:0.132 / U:4.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site