lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv2 1/5] Documentation: dt: edac: Fix Stratix10 IRQ bindings
From
Date
Hi Rob,

On 3/12/19 11:00 AM, Rob Herring wrote:
> On Wed, Feb 27, 2019 at 11:27:21AM -0600, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Fix Stratix10 ECC bindings to specify only the single
>> bit error. On Stratix10 double bit errors are handled
>> as SErrors instead of interrupts.
>> Indicate the differences between the ARM64 and ARM32
>> EDAC architecture in the bindings.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>> v2 No change
>> ---
>> .../devicetree/bindings/edac/socfpga-eccmgr.txt | 23 +++++++++++++++-------
>> 1 file changed, 16 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/edac/socfpga-eccmgr.txt b/Documentation/devicetree/bindings/edac/socfpga-eccmgr.txt
>> index 5626560a6cfd..a0ac50e15912 100644
>> --- a/Documentation/devicetree/bindings/edac/socfpga-eccmgr.txt
>> +++ b/Documentation/devicetree/bindings/edac/socfpga-eccmgr.txt
>> @@ -236,33 +236,42 @@ Stratix10 SoCFPGA ECC Manager
>> The Stratix10 SoC ECC Manager handles the IRQs for each peripheral
>> in a shared register similar to the Arria10. However, ECC requires
>> access to registers that can only be read from Secure Monitor with
>> -SMC calls. Therefore the device tree is slightly different.
>> +SMC calls. Therefore the device tree is slightly different. Note that
>> +only 1 interrupt is sent because the double bit errors are treated as
>> +SErrors instead of IRQ.
>>
>> Required Properties:
>> - compatible : Should be "altr,socfpga-s10-ecc-manager"
>> -- interrupts : Should be single bit error interrupt, then double bit error
>> - interrupt.
>> +- altr,sysgr-syscon : phandle to Stratix10 System Manager Block
>> + containing the ECC manager registers.
>
> Seems this was already in use, but why not just make this node a child
> of the System Manager Block and remove this phandle?
>
Yes, this was already in use but I'm trying to fix that oversight with
this patch.

The System Manager is a collection of registers used by different
peripherals including EMAC and ECC.

I view ECC Manager as a separate entity as is the Ethernet MAC which is
why I have it separate. Using the phandle also follows the convention
established with the Arria10 ECC Manager.

Thanks for the comments and for reviewing!

Thor

>> +- interrupts : Should be single bit error interrupt.
>> - interrupt-controller : boolean indicator that ECC Manager is an interrupt controller
>> - #interrupt-cells : must be set to 2.
>> +- #address-cells: must be 1
>> +- #size-cells: must be 1
>> +- ranges : standard definition, should translate from local addresses
>>
>> Subcomponents:
>>
>> SDRAM ECC
>> Required Properties:
>> - compatible : Should be "altr,sdram-edac-s10"
>> -- interrupts : Should be single bit error interrupt, then double bit error
>> - interrupt, in this order.
>> +- interrupts : Should be single bit error interrupt.
>>
>> Example:
>>
>> eccmgr {
>> compatible = "altr,socfpga-s10-ecc-manager";
>> - interrupts = <0 15 4>, <0 95 4>;
>> + altr,sysmgr-syscon = <&sysmgr>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + interrupts = <0 15 4>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> + ranges;
>>
>> sdramedac {
>> compatible = "altr,sdram-edac-s10";
>> - interrupts = <16 4>, <48 4>;
>> + interrupts = <16 IRQ_TYPE_LEVEL_HIGH>;
>> };
>> };
>> --
>> 2.7.4
>>
>

\
 
 \ /
  Last update: 2019-03-12 20:15    [W:0.069 / U:15.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site